Avoid loading full lodash #10308
Merged
Avoid loading full lodash #10308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
approved these changes
Jun 3, 2022
Codecov Report
@@ Coverage Diff @@
## main #10308 +/- ##
=====================================
- Coverage 64% 64% -1%
=====================================
Files 204 204
Lines 9295 9295
Branches 1505 1505
=====================================
- Hits 5966 5957 -9
- Misses 2857 2867 +10
+ Partials 472 471 -1
|
amunger
approved these changes
Jun 3, 2022
This reverts commit f3ebb12.
DonJayamanne
reviewed
Jun 4, 2022
| @@ -265,6 +265,7 @@ module.exports = { | |||
| ], | |||
| 'react/jsx-uses-vars': 'error', | |||
| 'react/jsx-uses-react': 'error', | |||
| 'no-restricted-imports': ['error', { "paths": ["lodash"] }], | |||
There was a problem hiding this comment.
Please add rxjs as well, as thats big as well.
Never mind, that can be a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #10307
Size reduced by 0.52 MB. We also introduced a new eslint rule to prevent this from happening in the future.