Support displaying complex mime types in Output Widget #10327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
force-pushed
the
issue9503Fixes
branch
from
3fb4388 to
0e5912a
Compare
DonJayamanne
commented
Jun 5, 2022
| @@ -30,7 +30,6 @@ import { CellExecutionCreator } from './cellExecutionCreator'; | |||
| import { IApplicationShell } from '../../platform/common/application/types'; | |||
| import { disposeAllDisposables } from '../../platform/common/helpers'; | |||
| import { traceError, traceWarning } from '../../platform/logging'; | |||
| import { RefBool } from '../../platform/common/refBool'; | |||
There was a problem hiding this comment.
Don't need such a class, all we need is a property (added comments what the property does with reference to Jupyter docs)
Codecov Report
@@ Coverage Diff @@
## main #10327 +/- ##
=======================================
Coverage 70% 71%
=======================================
Files 480 480
Lines 28946 29009 +63
Branches 4860 4886 +26
=======================================
+ Hits 20498 20633 +135
+ Misses 6543 6430 -113
- Partials 1905 1946 +41
|
DonJayamanne
force-pushed
the
issue9503Fixes
branch
from
b4b373b to
f3344fa
Compare
DonJayamanne
commented
Jun 8, 2022
| @@ -109,9 +109,14 @@ export function renderOutput(outputItem: OutputItem, element: HTMLElement, logge | |||
| } | |||
| export function disposeOutput(outputId?: string) { | |||
| if (outputId) { | |||
| const widget = renderedWidgets.get(outputId)?.widget; | |||
| renderedWidgets.delete(outputId); | |||
There was a problem hiding this comment.
We weren't deleting the entry in the map and weren't disposing the widget either.
DonJayamanne
commented
Jun 8, 2022
| * - Clearing the custom output that was appended after the output widget. | ||
| * - Appending custom output after the output widget | ||
| */ | ||
| private updateJupyterOutputWidgetWithOutput( |
There was a problem hiding this comment.
Todo: Should add more comments
DonJayamanne
force-pushed
the
issue9503Fixes
branch
from
3284a50 to
bf09a8f
Compare
|
I have to admit this is way to complicated to grok your algorithm. I just hope we have enough tests. |
rchiodo
approved these changes
Jun 9, 2022
Yes, I think we have enough. Wil test a little bit more and look for different output widget usages and add more tests. |
DonJayamanne
force-pushed
the
issue9503Fixes
branch
from
e5a2dfc to
d0e99b3
Compare
|
@rchiodo I'm going to merge this and will submit feature request (discuss with Rob & Matt) for the enhancements. |
DonJayamanne
force-pushed
the
issue9503Fixes
branch
from
d0e99b3 to
b2d9fc7
Compare
This was referenced Jun 17, 2022
DonJayamanne
added a commit
that referenced
this pull request
Jun 17, 2022
This reverts commit 94de3cd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9503