Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable widget support in other kernels #10331

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Enable widget support in other kernels #10331

merged 1 commit into from
Jun 6, 2022

Conversation

DonJayamanne
Copy link
Contributor

Fixes #10330

@DonJayamanne DonJayamanne requested a review from a team as a code owner June 6, 2022 01:30
DonJayamanne
DonJayamanne commented Jun 6, 2022
View reviewed changes
src/kernels/kernel.base.ts

// So that we don't have problems with ipywidgets, always register the default ipywidgets comm target.
// Restart sessions and retries might make this hard to do correctly otherwise.
session.registerCommTarget(Identifiers.DefaultCommTarget, noop);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now widgets from other kernels will work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jupyter.widget comm message is not specific to Python, ipywidgets is not specific to Python

@codecov-commenter
Copy link

Codecov Report

Merging #10331 (c3290f3) into main (ca8090c) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           main   #10331   +/-   ##
=====================================
  Coverage    63%      64%           
=====================================
  Files       204      204           
  Lines      9295     9295           
  Branches   1505     1505           
=====================================
+ Hits       5934     5959   +25     
+ Misses     2893     2866   -27     
- Partials    468      470    +2
Impacted Files Coverage Δ
src/platform/common/cancellation.ts 62% <0%> (-6%) ⬇️
.../platform/common/process/pythonEnvironment.node.ts 88% <0%> (+1%) ⬆️
src/platform/api/pythonApi.ts 69% <0%> (+2%) ⬆️
...ommon/process/environmentActivationService.node.ts 69% <0%> (+4%) ⬆️
src/platform/common/process/condaService.node.ts 71% <0%> (+5%) ⬆️

@DonJayamanne DonJayamanne merged commit 67e63a6 into main Jun 6, 2022
@DonJayamanne DonJayamanne deleted the enableWidgetSupportInOtherKernels branch June 6, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchiodo rchiodo rchiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Widgets in other kernels do not work in VS Code
3 participants
@DonJayamanne @codecov-commenter @rchiodo