Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kernel execution into the 'kernels' folder #10354

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

rchiodo
Copy link
Contributor

@rchiodo rchiodo commented Jun 7, 2022

For #10152

Still more to do after this but almost have 'notebooks' out of the 'kernels' folder.

@rchiodo rchiodo requested a review from a team as a code owner June 7, 2022 23:29
@codecov-commenter
Copy link

Codecov Report

Merging #10354 (94f287a) into main (98262a2) will decrease coverage by 0%.
The diff coverage is 76%.

@@          Coverage Diff          @@
##           main   #10354   +/-   ##
=====================================
- Coverage    64%      64%   -1%     
=====================================
  Files       212      212           
  Lines      9557     9559    +2     
  Branches   1527     1530    +3     
=====================================
- Hits       6159     6145   -14     
- Misses     2919     2935   +16     
  Partials    479      479           
Impacted Files Coverage Δ
src/platform/common/utils.ts 70% <68%> (-2%) ⬇️
src/platform/api/kernelApi.ts 72% <100%> (-1%) ⬇️
src/platform/common/activeEditorContext.ts 93% <100%> (ø)
...rc/platform/common/dataScienceSurveyBanner.node.ts 65% <100%> (-6%) ⬇️
...rc/platform/common/extensionRecommendation.node.ts 81% <100%> (ø)
src/platform/errors/errorUtils.ts 75% <100%> (+<1%) ⬆️
...tform/interpreter/display/visibilityFilter.node.ts 91% <100%> (ø)
src/platform/common/platform/fileSystem.ts 81% <0%> (-5%) ⬇️
src/platform/errors/errorHandler.ts 63% <0%> (-3%) ⬇️

@rchiodo rchiodo merged commit cf7da9f into main Jun 8, 2022
@rchiodo rchiodo deleted the rchiodo/kernel_no_notebook_4 branch June 8, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants