Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noop from external dependencies #10372

Merged
merged 2 commits into from
Jun 8, 2022
Merged

Remove noop from external dependencies #10372

merged 2 commits into from
Jun 8, 2022

Conversation

rebornix
Copy link
Member

@rebornix rebornix commented Jun 8, 2022

Re #10307

We don't need external modules to offer noop ;)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@rebornix rebornix marked this pull request as ready for review June 8, 2022 18:38
@rebornix rebornix requested a review from a team as a code owner June 8, 2022 18:38
@rebornix rebornix self-assigned this Jun 8, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #10372 (2f432b4) into main (cf7da9f) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           main   #10372   +/-   ##
=====================================
- Coverage    64%      64%   -1%     
=====================================
  Files       212      212           
  Lines      9559     9559           
  Branches   1530     1530           
=====================================
- Hits       6145     6143    -2     
- Misses     2935     2936    +1     
- Partials    479      480    +1     
Impacted Files Coverage Δ
src/platform/api/pythonApi.ts 69% <100%> (ø)
src/platform/errors/errorHandler.ts 62% <0%> (-1%) ⬇️

@rebornix rebornix merged commit 05ca1af into main Jun 8, 2022
@rebornix rebornix deleted the rebornix/noop branch June 8, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants