Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest of 'notebooks' removal from 'kernels' #10380

Merged
merged 9 commits into from
Jun 8, 2022
Merged

Conversation

rchiodo
Copy link
Contributor

@rchiodo rchiodo commented Jun 8, 2022

For #10152

This is the last of the 'notebooks' references in the 'kernels' folder.

Adding lint rule to reenforce this.

@rchiodo rchiodo requested a review from a team as a code owner June 8, 2022 22:21
@codecov-commenter
Copy link

Codecov Report

Merging #10380 (b7721b3) into main (fb7cd13) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           main   #10380   +/-   ##
=====================================
  Coverage    64%      64%           
=====================================
  Files       212      213    +1     
  Lines      9502     9506    +4     
  Branches   1525     1525           
=====================================
+ Hits       6144     6151    +7     
+ Misses     2876     2875    -1     
+ Partials    482      480    -2     
Impacted Files Coverage Δ
src/platform/common/utils/notebooks.ts 100% <100%> (ø)
src/platform/common/application/notebook.ts 86% <0%> (-5%) ⬇️
src/platform/api/kernelApi.ts 72% <0%> (+1%) ⬆️
src/platform/common/cancellation.ts 68% <0%> (+5%) ⬆️

@rchiodo rchiodo merged commit 28cb722 into main Jun 8, 2022
@rchiodo rchiodo deleted the rchiodo/kernel_no_notebooks_8 branch June 8, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants