Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSS messages dead code #10402

Merged
merged 9 commits into from
Jun 10, 2022
Merged

Remove CSS messages dead code #10402

merged 9 commits into from
Jun 10, 2022

Conversation

rchiodo
Copy link
Contributor

@rchiodo rchiodo commented Jun 9, 2022

Fixes #10304

@rchiodo rchiodo requested a review from a team as a code owner June 9, 2022 22:33
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #10402 (2c936b2) into main (080f35d) will increase coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           main   #10402      +/-   ##
========================================
+ Coverage    64%      69%      +4%     
========================================
  Files       213      479     +266     
  Lines      9506    29451   +19945     
  Branches   1525     5037    +3512     
========================================
+ Hits       6156    20540   +14384     
- Misses     2869     7013    +4144     
- Partials    481     1898    +1417     
Impacted Files Coverage Δ
src/platform/messageTypes.ts 100% <ø> (ø)
src/webviews/extension-side/variablesView/types.ts 100% <ø> (ø)
src/webviews/extension-side/plotting/types.ts 100% <100%> (ø)
src/webviews/extension-side/webviewHost.ts 74% <100%> (ø)
src/platform/errors/errorHandler.ts 62% <0%> (-1%) ⬇️
...ks/controllers/kernelFilter/kernelFilterService.ts 47% <0%> (ø)
src/kernels/raw/types.ts 100% <0%> (ø)
...rpreter/jupyterInterpreterSelectionCommand.node.ts 100% <0%> (ø)
...coordination/cdnWidgetScriptSourceProvider.base.ts 70% <0%> (ø)
src/kernels/jupyter/jupyterUriProviderWrapper.ts 55% <0%> (ø)
... and 262 more

if (!this.props.testMode) {
this.setState({
forceDark: newDark
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't forceDark used anywhere. if not we should remove that state prop

@rchiodo rchiodo merged commit 797af53 into main Jun 10, 2022
@rchiodo rchiodo deleted the rchiodo/remove_css branch June 10, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS messages are no longer generated
4 participants