Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semver usage #10416

Merged
merged 4 commits into from
Jun 10, 2022
Merged

Update semver usage #10416

merged 4 commits into from
Jun 10, 2022

Conversation

rebornix
Copy link
Member

Re #10307

Currently we are only using semver class on Desktop and import semver types on Web (which can be replaced with our typings though). This PR moves where we check local python path and check python version through semver into node specific code path. With this change, semver is no longer included in Web bundle.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@rebornix rebornix marked this pull request as ready for review June 10, 2022 17:23
@rebornix rebornix requested a review from a team as a code owner June 10, 2022 17:23
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2022

Codecov Report

Merging #10416 (19050eb) into main (d3f539e) will decrease coverage by 0%.
The diff coverage is 76%.

❗ Current head 19050eb differs from pull request most recent head bd5cd85. Consider uploading reports for the commit bd5cd85 to get more accurate results

@@          Coverage Diff           @@
##            main   #10416   +/-   ##
======================================
- Coverage     69%      69%   -1%     
======================================
  Files        479      479           
  Lines      29460    29452    -8     
  Branches    5038     5039    +1     
======================================
- Hits       20553    20547    -6     
+ Misses      7009     7004    -5     
- Partials    1898     1901    +3     
Impacted Files Coverage Δ
src/intellisense/notebookPythonPathService.node.ts 45% <ø> (ø)
src/platform/common/platform/types.ts 100% <ø> (ø)
src/platform/common/utils.ts 69% <ø> (-1%) ⬇️
...form/pythonEnvironments/info/pythonVersion.node.ts 71% <71%> (ø)
src/platform/common/utils.node.ts 58% <75%> (+4%) ⬆️
src/intellisense/intellisenseProvider.node.ts 83% <100%> (ø)
src/intellisense/serviceRegistry.node.ts 100% <100%> (ø)
...eter/nbconvertInterpreterDependencyChecker.node.ts 95% <100%> (ø)
...atform/pythonEnvironments/info/interpreter.node.ts 76% <100%> (ø)
...ide/dataviewer/dataViewerDependencyService.node.ts 86% <100%> (ø)
... and 5 more

@rebornix rebornix merged commit d6471f9 into main Jun 10, 2022
@rebornix rebornix deleted the rebornix/semver branch June 10, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants