Service container registrations update #10475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornix
commented
Jun 16, 2022
| @@ -7,11 +7,19 @@ import { IExtensionSingleActivationService, IExtensionSyncActivationService } fr | |||
| import { IServiceManager } from '../platform/ioc/types'; | |||
| import { NotebookCellBangInstallDiagnosticsProvider } from './diagnosticsProvider'; | |||
| import { IntellisenseProvider } from './intellisenseProvider.node'; | |||
| import { LogReplayService } from './logReplayService.node'; | |||
There was a problem hiding this comment.
logReplayService registered directly in intellisense
rebornix
commented
Jun 16, 2022
| @@ -63,4 +64,9 @@ export function registerTypes(serviceManager: IServiceManager) { | |||
| undefined, | |||
| [IExtensionSingleActivationService] | |||
| ); | |||
| serviceManager.addSingleton<IJupyterExtensionBanner>( | |||
There was a problem hiding this comment.
InteractiveShiftEnterBanner registered directly in src/interactive-window
rebornix
commented
Jun 16, 2022
| @@ -86,4 +87,9 @@ export function registerTypes(serviceManager: IServiceManager, isDevMode: boolea | |||
| registerJupyterTypes(serviceManager, isDevMode); | |||
|
|
|||
| serviceManager.addSingleton<CellOutputDisplayIdTracker>(CellOutputDisplayIdTracker, CellOutputDisplayIdTracker); | |||
|
|
|||
| // debugging | |||
| serviceManager.addSingleton<IDebugLocationTracker>(IDebugLocationTracker, DebugLocationTrackerFactory, undefined, [ | |||
There was a problem hiding this comment.
DebugLocationTrackerFactory registered in src/kernels.
rebornix
commented
Jun 16, 2022
| @@ -89,4 +90,8 @@ export function registerTypes(serviceManager: IServiceManager) { | |||
| IExtensionSingleActivationService, | |||
| EmptyNotebookCellLanguageService | |||
| ); | |||
|
|
|||
| serviceManager.addSingleton<IDebuggingManager>(IDebuggingManager, DebuggingManager, undefined, [ | |||
There was a problem hiding this comment.
DebuggingManager registered directly in src/notebooks
rebornix
commented
Jun 16, 2022
|
|
||
| export function registerTypes(serviceManager: IServiceManager, _isDevMode: boolean) { | ||
| serviceManager.add<IWebviewViewProvider>(IWebviewViewProvider, WebviewViewProvider); | ||
| serviceManager.add<IWebviewPanelProvider>(IWebviewPanelProvider, WebviewPanelProvider); | ||
|
|
There was a problem hiding this comment.
DataViewer, Varaible Views and renderer registration moved out of src/platform
rchiodo
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #10152
This is part of refactoring
src/platformand the PR is mostly moving type registrations fromsrc/platforminto where they are implemented, i.e, kernel type should be registered insrc/kernels.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).