Service registration refactor part 2 #10479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornix
commented
Jun 16, 2022
|
|
||
| export function registerTypes(serviceManager: IServiceManager, _isDevMode: boolean) { | ||
| serviceManager.addSingleton<IExtensionSingleActivationService>(IExtensionSingleActivationService, GlobalActivation); |
There was a problem hiding this comment.
GlobalActivation, ExtensionRecommendationService, ActiveEditorContextService, AmlComputeContext, ImportTracker are now registered in extension-side, instead of src/platform
rebornix
commented
Jun 16, 2022
|
|
||
| export function registerTypes(serviceManager: IServiceManager, isDevMode: boolean) { | ||
| serviceManager.addSingleton<IExtensionSingleActivationService>(IExtensionSingleActivationService, Activation); | ||
|
|
||
| serviceManager.addSingleton<IExtensionSyncActivationService>( |
There was a problem hiding this comment.
PortAttributesProviders registration moved from platform to kernels.
rebornix
commented
Jun 16, 2022
| @@ -1,8 +1,8 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
There was a problem hiding this comment.
Kernel related errors are moved into src/kernels/errors instead of having them in src/platform.
rchiodo
approved these changes
Jun 16, 2022
|
Thanks @rchiodo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #10152. Continue to move service registration into feature component from platform. This PR itself is a bit large but they are mostly moving files.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).