Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: notebook export #10487

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Refactor: notebook export #10487

merged 2 commits into from
Jun 17, 2022

Conversation

rebornix
Copy link
Member

@rebornix rebornix commented Jun 17, 2022

Re #10152

Export to HTML/PDF/Python is a feature on notebook document, and can be reused by interactive window. Thus we move it out of platform and embed in src/notebooks.

This PR is purely file movement.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@rebornix rebornix self-assigned this Jun 17, 2022
@rebornix rebornix marked this pull request as ready for review June 17, 2022 01:23
@rebornix rebornix requested a review from a team as a code owner June 17, 2022 01:23
@codecov-commenter
Copy link

Codecov Report

Merging #10487 (b9d1376) into main (4ed91b2) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##            main   #10487   +/-   ##
======================================
- Coverage     71%      71%   -1%     
======================================
  Files        486      486           
  Lines      29161    29161           
  Branches    4902     4902           
======================================
- Hits       20760    20757    -3     
- Misses      6441     6450    +9     
+ Partials    1960     1954    -6     
Impacted Files Coverage Δ
src/notebooks/export/exportToHTML.ts 100% <ø> (ø)
src/notebooks/export/exportToPDF.ts 66% <ø> (ø)
src/notebooks/export/exportToPython.ts 100% <ø> (ø)
src/notebooks/export/types.ts 100% <ø> (ø)
src/platform/serviceRegistry.node.ts 100% <ø> (ø)
src/telemetry/types.ts 100% <ø> (ø)
src/interactive-window/interactiveWindow.ts 73% <100%> (ø)
...ractive-window/interactiveWindowCommandListener.ts 37% <100%> (ø)
...rc/interactive-window/interactiveWindowProvider.ts 78% <100%> (ø)
src/notebooks/export/exportBase.node.ts 73% <100%> (ø)
... and 18 more

@rebornix rebornix merged commit 3558542 into main Jun 17, 2022
@rebornix rebornix deleted the rebornix/notebook-export branch June 17, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants