-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate python/intepreter api and extension api #10494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering what platform is anymore? You're moving 'global' things to webviews/extension-side, but isn't it the same as being platform? What does platform represent if not global things?
Codecov Report
@@ Coverage Diff @@
## main #10494 +/- ##
======================================
- Coverage 71% 71% -1%
======================================
Files 467 467
Lines 28072 28073 +1
Branches 4736 4736
======================================
- Hits 19959 19935 -24
- Misses 6230 6251 +21
- Partials 1883 1887 +4
|
Discussed with @rchiodo offline about the wording and definitions, especially around what "global" means in the context. There are two types of "global" components. The first group includes utilities( During my refactoring, I tried to use
@microsoft/datascience-vsc-team-reviewers thoughts? |
Re #10152
There are two types of APIs
extension.d.ts
This PR attempts to separate these two. The first group API sits in
platform
and can be used by other components, while the extension api is moved out ofplatform
and should not be used by any internal/primitive component.package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).