Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kernel error types #10497

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Move kernel error types #10497

merged 2 commits into from
Jun 20, 2022

Conversation

rebornix
Copy link
Member

Re #10152

Only a few types placed in the wrong folders left then we can have all our eslint rules ready. This PR moves kernel related kernel types into src/kernels.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@rebornix rebornix self-assigned this Jun 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #10497 (0a5bd63) into main (b821681) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##            main   #10497   +/-   ##
======================================
- Coverage     71%      71%   -1%     
======================================
  Files        467      468    +1     
  Lines      28073    28076    +3     
  Branches    4736     4736           
======================================
- Hits       19944    19942    -2     
- Misses      6239     6249   +10     
+ Partials    1890     1885    -5     
Impacted Files Coverage Δ
src/interactive-window/interactiveWindow.ts 74% <ø> (ø)
src/platform/common/utils.ts 80% <ø> (ø)
src/platform/errors/types.ts 72% <ø> (-8%) ⬇️
...teractive-window/editor-integration/codewatcher.ts 71% <100%> (ø)
...ractive-window/interactiveWindowCommandListener.ts 39% <100%> (ø)
...rc/interactive-window/interactiveWindowProvider.ts 77% <100%> (ø)
...kernels/errors/jupyterDebuggerNotInstalledError.ts 50% <100%> (ø)
src/kernels/errors/jupyterInvalidKernelError.ts 62% <100%> (ø)
src/kernels/errors/jupyterKernelDependencyError.ts 100% <100%> (ø)
src/kernels/errors/jupyterWaitForIdleError.ts 100% <100%> (ø)
... and 25 more

@rebornix rebornix marked this pull request as ready for review June 20, 2022 16:29
@rebornix rebornix requested a review from a team as a code owner June 20, 2022 16:29
@rebornix rebornix merged commit db5b41f into main Jun 20, 2022
@rebornix rebornix deleted the rebornix/update-kernel-error branch June 20, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants