Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension activation and context registration #10520

Merged
merged 3 commits into from
Jun 21, 2022

Conversation

rebornix
Copy link
Member

Re #10152

Group extension activation and context update related code into sub folders

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@rebornix rebornix requested a review from a team as a code owner June 21, 2022 17:34
@rebornix rebornix self-assigned this Jun 21, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #10520 (edf006d) into main (669d502) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##            main   #10520   +/-   ##
======================================
- Coverage     71%      71%   -1%     
======================================
  Files        468      468           
  Lines      28103    28071   -32     
  Branches    4747     4742    -5     
======================================
- Hits       19976    19948   -28     
+ Misses      6247     6240    -7     
- Partials    1880     1883    +3     
Impacted Files Coverage Δ
src/kernels/installer/productInstaller.node.ts 74% <ø> (+12%) ⬆️
src/platform/activation/types.ts 100% <ø> (ø)
...ews/extension-side/activation/activationManager.ts 100% <ø> (ø)
...iews/extension-side/activation/globalActivation.ts 92% <100%> (ø)
...ension-side/activation/workspaceActivation.node.ts 56% <100%> (ø)
...iews/extension-side/context/activeEditorContext.ts 93% <100%> (ø)
...webviews/extension-side/context/amlContext.node.ts 90% <100%> (ø)
...rc/webviews/extension-side/serviceRegistry.node.ts 100% <100%> (ø)
src/kernels/errors/jupyterInvalidKernelError.ts 62% <0%> (-38%) ⬇️
src/platform/common/cancellation.ts 59% <0%> (-10%) ⬇️
... and 10 more

@rebornix rebornix merged commit 49385ce into main Jun 21, 2022
@rebornix rebornix deleted the rebornix/extension-activation branch June 21, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants