Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move devtools out of platform #10522

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Move devtools out of platform #10522

merged 1 commit into from
Jun 21, 2022

Conversation

rebornix
Copy link
Member

Re #10152

This PR

  • Moves devtools out of platform
  • Move isPythonNotebook into kernels for now as this helper reads kernel metadata info

This is the last piece before we turn on all eslint rules and consolidate our typings protection (for telemetry, commands and webview message types, will discuss in standup). With this change, we have no layer breaking imports.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@rebornix rebornix requested a review from a team as a code owner June 21, 2022 20:37
@rebornix rebornix self-assigned this Jun 21, 2022
@rebornix rebornix merged commit 150d596 into main Jun 21, 2022
@rebornix rebornix deleted the rebornix/movedevtools branch June 21, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants