Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslintrc import restriction rules #10535

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

rebornix
Copy link
Member

Re #10152

After experimenting moving all webviews into standalone/webviews I found that change is siganificantly large and I'm also not seeing obvious benefits of doing that. If I want to find a feature related to webview, it's kind of weird that I need to go to standalone and then webviews, and lastly have to browse in both extension-side and webview-side.

webviews is still probably a good top component, where all features related to webview just go into that. Other features go into standalone.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@rebornix rebornix requested a review from a team as a code owner June 22, 2022 16:32
@rebornix rebornix self-assigned this Jun 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #10535 (e04cf23) into main (9bb8955) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##            main   #10535   +/-   ##
======================================
- Coverage     71%      71%   -1%     
======================================
  Files        464      465    +1     
  Lines      27902    27905    +3     
  Branches    4699     4699           
======================================
- Hits       19834    19829    -5     
- Misses      6197     6200    +3     
- Partials    1871     1876    +5     
Impacted Files Coverage Δ
src/platform/messageTypes.ts 100% <ø> (ø)
src/standalone/serviceRegistry.node.ts 100% <ø> (ø)
src/telemetry/types.ts 100% <ø> (ø)
src/extension.node.ts 76% <100%> (+<1%) ⬆️
src/platform/serviceRegistry.node.ts 100% <100%> (ø)
src/standalone/import-export/exportCommands.ts 44% <100%> (ø)
...rc/webviews/extension-side/serviceRegistry.node.ts 100% <100%> (ø)
.../standalone/survey/dataScienceSurveyBanner.node.ts 66% <0%> (-6%) ⬇️
src/standalone/api/kernelApi.ts 71% <0%> (-2%) ⬇️
src/kernels/execution/cellExecutionQueue.ts 81% <0%> (-2%) ⬇️
... and 8 more

@rebornix
Copy link
Member Author

The test failures are unrelated to my change.

@rebornix rebornix merged commit f274826 into main Jun 22, 2022
@rebornix rebornix deleted the rebornix/keep-webview-as-top-component branch June 22, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants