Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra button from Restart Kernel modal #10539

Merged
merged 3 commits into from
Jun 22, 2022
Merged

Remove extra button from Restart Kernel modal #10539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61ae35c
Remove extra button from Restart Kernel modal
kilacoda Jun 22, 2022
2c9508f
Remove extra button from Restart Kernel modal (#10539)
kilacoda Jun 22, 2022
3e5823c
Update 10539.md
rchiodo Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/2 Fixes/10539.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove extra button from Restart Kernel modal. (Thanks [kilacoda](https://github.com/kilacoda))
4 changes: 1 addition & 3 deletions src/notebooks/notebookCommandListener.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,14 +214,12 @@ export class NotebookCommandListener implements IDataScienceCommandListener {
const message = DataScience.restartKernelMessage();
const yes = DataScience.restartKernelMessageYes();
const dontAskAgain = DataScience.restartKernelMessageDontAskAgain();
const no = DataScience.restartKernelMessageNo();

const response = await this.applicationShell.showInformationMessage(
message,
{ modal: true },
yes,
dontAskAgain,
no
dontAskAgain
);
if (response === dontAskAgain) {
await this.disableAskForRestart(document.uri);
Expand Down