-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix running latex cell with cell marker #10556
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10556 +/- ##
======================================
- Coverage 71% 71% -1%
======================================
Files 472 472
Lines 27987 27993 +6
Branches 4689 4691 +2
======================================
+ Hits 19919 19921 +2
- Misses 6190 6191 +1
- Partials 1878 1881 +3
|
@@ -84,6 +84,51 @@ suite('Code Generator Unit Tests', () => { | |||
assert.equal(generatedCodes[0].generatedCodes[0].executionCount, 1, 'Wrong execution count'); | |||
}); | |||
|
|||
test('Execute %%latex magic in a cell with a cell marker', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha, I was about to mention that this change was a good candidate for unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to add an integration test as this was a bad break, basically as bad as not being able to run a cell.
To me this is a golden scenario, not being able to run latext cells in IW.
Fixes #10531