Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running latex cell with cell marker #10556

Merged
merged 7 commits into from
Jun 24, 2022
Merged

Fix running latex cell with cell marker #10556

merged 7 commits into from
Jun 24, 2022

Conversation

DonJayamanne
Copy link
Contributor

Fixes #10531

@DonJayamanne DonJayamanne requested a review from a team as a code owner June 23, 2022 21:41
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71%. Comparing base (e09de76) to head (23a1e29).
Report is 1796 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #10556   +/-   ##
======================================
- Coverage     71%      71%   -1%     
======================================
  Files        472      472           
  Lines      27987    27993    +6     
  Branches    4689     4691    +2     
======================================
+ Hits       19919    19921    +2     
- Misses      6190     6191    +1     
- Partials    1878     1881    +3     
Files with missing lines Coverage Δ
...ractive-window/editor-integration/codeGenerator.ts 91% <100%> (+<1%) ⬆️

... and 27 files with indirect coverage changes

@@ -84,6 +84,51 @@ suite('Code Generator Unit Tests', () => {
assert.equal(generatedCodes[0].generatedCodes[0].executionCount, 1, 'Wrong execution count');
});

test('Execute %%latex magic in a cell with a cell marker', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, I was about to mention that this change was a good candidate for unit tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to add an integration test as this was a bad break, basically as bad as not being able to run a cell.
To me this is a golden scenario, not being able to run latext cells in IW.

@DonJayamanne DonJayamanne merged commit 440397a into main Jun 24, 2022
@DonJayamanne DonJayamanne deleted the issue10531 branch June 24, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"SyntaxError: unexpected character after line continuation character" pops up
4 participants