-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token test fix #10564
Token test fix #10564
Conversation
Codecov Report
@@ Coverage Diff @@
## main #10564 +/- ##
========================================
- Coverage 71% 56% -15%
========================================
Files 472 472
Lines 27993 27993
Branches 4691 4691
========================================
- Hits 19946 15947 -3999
- Misses 6179 10504 +4325
+ Partials 1868 1542 -326
|
@@ -126,18 +126,13 @@ suite('DataScience - VSCode semantic token tests', function () { | |||
await insertCodeCell( | |||
'import sqllite3 as sql\n\nconn = sql.connect("test.db")\ncur = conn.cursor()\n# BLAH BLAH' | |||
); | |||
await insertCodeCell('\n'); | |||
await insertCodeCell( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why it was building the document like this, but it didn't seem relevant to the test and it was having issues on CI (second cell wasn't populated).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why the cell wasn't being added, but I believe this test was verifying editing cells gets semantic tokens.
Fixes #10565
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).