Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token test fix #10564

Merged
merged 3 commits into from
Jun 24, 2022
Merged

Token test fix #10564

merged 3 commits into from
Jun 24, 2022

Conversation

IanMatthewHuff
Copy link
Member

@IanMatthewHuff IanMatthewHuff commented Jun 24, 2022

Fixes #10565

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #10564 (3bbc6ff) into main (440397a) will decrease coverage by 14%.
The diff coverage is n/a.

❗ Current head 3bbc6ff differs from pull request most recent head 597ec78. Consider uploading reports for the commit 597ec78 to get more accurate results

@@           Coverage Diff            @@
##            main   #10564     +/-   ##
========================================
- Coverage     71%      56%    -15%     
========================================
  Files        472      472             
  Lines      27993    27993             
  Branches    4691     4691             
========================================
- Hits       19946    15947   -3999     
- Misses      6179    10504   +4325     
+ Partials    1868     1542    -326     
Impacted Files Coverage Δ
src/notebooks/outputs/tracebackFormatter.ts 24% <0%> (-76%) ⬇️
src/kernels/debugger/kernelDebugAdapterBase.ts 6% <0%> (-74%) ⬇️
...ve-window/debugger/jupyter/debugCellControllers.ts 23% <0%> (-74%) ⬇️
...views/extension-side/variablesView/variableView.ts 17% <0%> (-73%) ⬇️
src/interactive-window/interactiveWindow.ts 7% <0%> (-68%) ⬇️
src/interactive-window/debugger/helper.ts 33% <0%> (-67%) ⬇️
src/notebooks/export/exportToPythonPlain.ts 21% <0%> (-66%) ⬇️
src/notebooks/debugger/kernelDebugAdapter.ts 20% <0%> (-65%) ⬇️
src/platform/webviews/webviewPanelProvider.ts 12% <0%> (-64%) ⬇️
src/interactive-window/helpers.ts 36% <0%> (-64%) ⬇️
... and 213 more

@@ -126,18 +126,13 @@ suite('DataScience - VSCode semantic token tests', function () {
await insertCodeCell(
'import sqllite3 as sql\n\nconn = sql.connect("test.db")\ncur = conn.cursor()\n# BLAH BLAH'
);
await insertCodeCell('\n');
await insertCodeCell(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why it was building the document like this, but it didn't seem relevant to the test and it was having issues on CI (second cell wasn't populated).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the cell wasn't being added, but I believe this test was verifying editing cells gets semantic tokens.

@IanMatthewHuff IanMatthewHuff marked this pull request as ready for review June 24, 2022 19:05
@IanMatthewHuff IanMatthewHuff requested a review from a team as a code owner June 24, 2022 19:05
@IanMatthewHuff IanMatthewHuff merged commit d6b546f into main Jun 24, 2022
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/tokenTestFix branch June 24, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Special Token Check' is failing continually on CI
3 participants