Simply script uri converter #10728
Merged
Simply script uri converter #10728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Jul 7, 2022
| // Make a copy of the local file if not already in the correct location | ||
| if (!this.isInScriptPath(localResource)) { | ||
| const key = getComparisonKey(localResource); | ||
| if (!this.resourcesMappedToExtensionFolder.has(key)) { |
There was a problem hiding this comment.
This is no longer required. We copy the entire nbextensions folders now, instead of copying a single file
sadasant
reviewed
Jul 7, 2022
sadasant
approved these changes
Jul 7, 2022
Codecov Report
@@ Coverage Diff @@
## main #10728 +/- ##
======================================
- Coverage 62% 62% -1%
======================================
Files 476 476
Lines 32985 32983 -2
Branches 5356 5356
======================================
- Hits 20748 20719 -29
- Misses 10254 10270 +16
- Partials 1983 1994 +11
|
DonJayamanne
force-pushed
the
simplifyUriConverter
branch
from
9d7f984 to
19fbf6f
Compare
DonJayamanne
commented
Jul 7, 2022
| * The converter will post an event when it needs to convert the webview URI | ||
| */ | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| requestUri: Event<Uri>; |
There was a problem hiding this comment.
Removed this event.
I personally think its simpler to read the code by firing a method to get information as opposed to firing an event to ask for information.
Events - fire and forget, and method (callbacks) mean we need a result.
IanMatthewHuff
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.