Hotfix: Stop using vscode-nls for some key localizations #10773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
approved these changes
Jul 12, 2022
Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com>
DonJayamanne
approved these changes
Jul 12, 2022
|
I have also made an issue to follow up on the re-introduction of these localizations: #10774 |
sadasant
added a commit
to sadasant/vscode-jupyter
that referenced
this pull request
Jul 12, 2022
…0773) * Hotfix: Stop using vscode-nls for some key localizations * news * Update news/2 Fixes/10752.md Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com>
sadasant
added a commit
that referenced
this pull request
Jul 12, 2022
…0775) * Hotfix: Stop using vscode-nls for some key localizations (#10773) * Hotfix: Stop using vscode-nls for some key localizations * news * Update news/2 Fixes/10752.md Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> * Other changes needed for the hotfix release * 2022.6.101 to 2022.6.110 Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com>
sadasant
added a commit
that referenced
this pull request
Jul 14, 2022
)" This reverts commit 9caa26d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR undoes localization on some localization keys that are breaking the related features of the
vscode-jupyterextension.Last week we released version 6.100 of the
vscode-jupyter. Unbeknown to us, the extension shipped with some of its features broken. Customers began reporting that some of the commands, like the one for restarting kernels and the one for interrupting kernels, were missing from the UI.In the developer tools of VSCode (version 1.69.0 and above), when 6.100 is loaded, we see a large influx of error messages:
While debugging, we realized that:
package.jsonto use existing keys pointing to other localized phrases bypasses the problem.package.jsonto use plain strings also bypasses the problem.This PR aims to replace all of the problematic localizations for plain text English strings in order to deliver a hotfix for 6.100.
The changes included in this PR do make all of the errors shown in the screenshot go away.
(Once released)
Fixes microsoft/vscode#154955