-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix problem when restarting right after debugging #10783
Conversation
Codecov Report
@@ Coverage Diff @@
## main #10783 +/- ##
======================================
- Coverage 62% 62% -1%
======================================
Files 476 476
Lines 33048 33058 +10
Branches 5387 5391 +4
======================================
- Hits 20736 20733 -3
- Misses 10274 10279 +5
- Partials 2038 2046 +8
|
await this.session.customRequest('disconnect', { restart: false }); | ||
} | ||
this.endSession.fire(this.session); | ||
this.disconnected = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move this property initialization to the very top (just after checking it), else this method disconnect
can be called multiple times and we could end up sending multiple disconnect
requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggested change to prevent duplicate disconnect
requests being sent out
Fixes #10741
I don't think this was an actual regression, but rather a papercut. Super easy fix though.