Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Python Getting Started page in the Install Extension workflow #10794

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

IanMatthewHuff
Copy link
Member

Fixes #10793

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@IanMatthewHuff
Copy link
Member Author

Just a quick change to consume the option that Logan added on the vscode core side. Let's us install while preventing getting started from popping up.

@@ -177,8 +171,7 @@ export class InstallPythonControllerCommands implements IExtensionSingleActivati
// Now start to indicate that we are performing the install and locating kernels
const reporter = this.progressReporter.createProgressIndicator(DataScience.installingPythonExtension());
try {
// Directly install the python extension
await this.commandManager.executeCommand('workbench.extensions.installExtension', PythonExtension);
await this.extensionChecker.directlyInstallPythonExtension();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had added a helper function before and forgot to use it, so swapped it in now.

@IanMatthewHuff IanMatthewHuff marked this pull request as ready for review July 13, 2022 19:29
@IanMatthewHuff IanMatthewHuff requested a review from a team as a code owner July 13, 2022 19:29
@codecov-commenter
Copy link

Codecov Report

Merging #10794 (c6c62c9) into main (708004b) will decrease coverage by 0%.
The diff coverage is 33%.

@@          Coverage Diff           @@
##            main   #10794   +/-   ##
======================================
- Coverage     62%      62%   -1%     
======================================
  Files        476      476           
  Lines      33048    33058   +10     
  Branches    5387     5391    +4     
======================================
+ Hits       20736    20738    +2     
- Misses     10274    10277    +3     
- Partials    2038     2043    +5     
Impacted Files Coverage Δ
src/platform/api/pythonApi.ts 69% <0%> (ø)
...ollers/commands/installPythonControllerCommands.ts 57% <50%> (ø)
src/platform/common/cancellation.ts 64% <0%> (-4%) ⬇️
src/platform/telemetry/telemetry.ts 76% <0%> (-4%) ⬇️
.../kernels/raw/launcher/kernelEnvVarsService.node.ts 68% <0%> (-3%) ⬇️
src/kernels/debugger/kernelDebugAdapterBase.ts 76% <0%> (-3%) ⬇️
src/standalone/api/kernelApi.ts 72% <0%> (-2%) ⬇️
...ommon/process/environmentActivationService.node.ts 71% <0%> (-1%) ⬇️
src/platform/common/utils/localize.ts 76% <0%> (-1%) ⬇️
...tive-window/debugger/jupyter/kernelDebugAdapter.ts 58% <0%> (ø)
... and 6 more

@IanMatthewHuff IanMatthewHuff merged commit 2f994c3 into main Jul 14, 2022
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/hideGettingStarted branch July 14, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide the Python getting started page when installing Python Extension via the Kernel Picker command
4 participants