-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use python.envFile to get env file name when running Python code #10876
Conversation
src/platform/common/variables/customEnvironmentVariablesProvider.node.ts
Outdated
Show resolved
Hide resolved
import { IPythonExtensionChecker } from '../../../../../platform/api/types'; | ||
import { createEventHandler } from '../../../../common'; | ||
|
||
suite('Custom Environment Variables Provider', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could these be unit tests? Doesn't seem to requre vscode to be running
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rely on vscode here as I'm using the VS Code API to create the file watcher and i don't want to mock that, too much work and not worth it at all.
Here we have 6 test and everything runs in <1s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amunger looks like i'll have to create unit tests and mock the vscode classes, as the file change detection doesn't work on CI, possibly due to a large number of files or other.
d44908b
to
df0c788
Compare
Codecov Report
@@ Coverage Diff @@
## main #10876 +/- ##
======================================
Coverage 63% 63%
======================================
Files 486 489 +3
Lines 33791 33863 +72
Branches 5502 5508 +6
======================================
+ Hits 21408 21492 +84
+ Misses 10342 10327 -15
- Partials 2041 2044 +3
|
Fixes #9691