Remove controllers from ThirdParty Kernels #10884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #10884 +/- ##
======================================
Coverage 63% 63%
======================================
Files 488 488
Lines 33827 33873 +46
Branches 5508 5513 +5
======================================
+ Hits 21442 21514 +72
+ Misses 10337 10318 -19
+ Partials 2048 2041 -7
|
8 tasks
DonJayamanne
force-pushed
the
removeControllerFrom3rdParty
branch
from
a60f632
to
b3d29c8
Compare
sadasant
reviewed
Jul 21, 2022
| private readonly documentExecutions = new WeakMap<NotebookDocument, CellExecutionQueue>(); | ||
| private readonly executionFactory: CellExecutionFactory; | ||
| private readonly disposables: IDisposable[] = []; | ||
| export class BaseKernelExecution<TKernel extends IBaseKernel = IBaseKernel> implements IDisposable { |
There was a problem hiding this comment.
Could the base class live in a different file? Not sure if that's preferable or not
There was a problem hiding this comment.
Can, sometimes i find it useful to be in one place, else theres a lot of going back and forth..
However Will change
There was a problem hiding this comment.
Damn it, forgot this, will do in debt week
rchiodo
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10832