Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems with launching non zmq on windows #10944

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Conversation

rchiodo
Copy link
Contributor

@rchiodo rchiodo commented Jul 26, 2022

Fixes #10940

Root cause seems to be the case of the environment variable keys. Jupyter must have code that uses os.environ["PATH"] somewhere.

Before change 7308db8 my kernelspec.json had PATH in upper case. After that change, it switched to lower case.

@rchiodo rchiodo requested a review from a team as a code owner July 26, 2022 23:30
@rchiodo rchiodo merged commit 69fc357 into main Jul 27, 2022
@rchiodo rchiodo deleted the rchiodo/fix_jupter_launch branch July 27, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non ZMQ doesn't work
2 participants