Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use builtin alias, allow user to overwrite builtin #10988

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Conversation

DonJayamanne
Copy link
Contributor

Fixes #10941

@DonJayamanne DonJayamanne requested a review from a team as a code owner July 31, 2022 17:17
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2022

Codecov Report

Merging #10988 (8f48598) into main (5ff36bf) will decrease coverage by 0%.
The diff coverage is n/a.

❗ Current head 8f48598 differs from pull request most recent head 7bfc4bd. Consider uploading reports for the commit 7bfc4bd to get more accurate results

@@          Coverage Diff           @@
##            main   #10988   +/-   ##
======================================
- Coverage     63%      63%   -1%     
======================================
  Files        482      482           
  Lines      33851    33851           
  Branches    5518     5518           
======================================
- Hits       21501    21474   -27     
- Misses     10317    10339   +22     
- Partials    2033     2038    +5     
Impacted Files Coverage Δ
src/kernels/common/chainingExecuteRequester.ts 66% <0%> (-17%) ⬇️
src/platform/common/cancellation.ts 64% <0%> (-8%) ⬇️
src/kernels/execution/cellExecution.ts 72% <0%> (-8%) ⬇️
src/platform/common/process/baseDaemon.node.ts 50% <0%> (-4%) ⬇️
src/kernels/jupyter/baseKernelConnectionWrapper.ts 35% <0%> (-3%) ⬇️
src/kernels/jupyter/jupyterKernelService.node.ts 74% <0%> (-2%) ⬇️
src/kernels/kernelFinder.base.ts 82% <0%> (-2%) ⬇️
src/kernels/common/baseJupyterSession.ts 80% <0%> (-1%) ⬇️
src/notebooks/debugger/kernelDebugAdapterBase.ts 79% <0%> (ø)
src/kernels/raw/launcher/kernelProcess.node.ts 70% <0%> (+<1%) ⬆️
... and 2 more

@DonJayamanne DonJayamanne merged commit 5d12ab7 into main Aug 2, 2022
@DonJayamanne DonJayamanne deleted the issue10941 branch August 2, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataviewer fails when builtins are overridden with user variables
3 participants