-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packages and npm version #11025
Conversation
"fs-path": "0.0.25", | ||
"simple-get@<3.1.1": "3.1.1", | ||
"validator@<13.7.0": "13.7.0", | ||
"jpeg-js@<0.4.4": "0.4.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using @<
so that any package that depends on a later version will still get the later version instead of what we specific here.
I.e. we need to ensure we pin only to a specific version unless absolutely necessary.
@@ -14,7 +14,7 @@ | |||
### Prerequisites | |||
|
|||
1. [Node.js](https://nodejs.org/) 16.14.2 | |||
2. [npm](https://www.npmjs.com/) 8.3.0 | |||
2. [npm](https://www.npmjs.com/) 8.15.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Older versions are buggy
@@ -2493,8 +2493,15 @@ | |||
"fsevents": "^2.3.2" | |||
}, | |||
"overrides": { | |||
"simple-get": "3.1.1", | |||
"fs-path": "0.0.25", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fs-path
is not used anywhere, hence this isn't required.
Codecov Report
@@ Coverage Diff @@
## main #11025 +/- ##
=======================================
- Coverage 63% 62% -1%
=======================================
Files 482 482
Lines 33819 33819
Branches 5510 5510
=======================================
- Hits 21353 21137 -216
- Misses 10430 10601 +171
- Partials 2036 2081 +45
|
Fixes #11013