Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing nbconvert CI test by generating a proper temp ipynb file #11191

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

IanMatthewHuff
Copy link
Member

@IanMatthewHuff IanMatthewHuff commented Aug 25, 2022

Fixes #11190

Working on getting branch all green for release.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

},
nbformat: 4,
nbformat_minor: 2,
kernel: {
Copy link
Member Author

@IanMatthewHuff IanMatthewHuff Aug 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an invalid INotebookContent and nbconvert wasn't liking the kernel entry as it's not part of the spec.

@IanMatthewHuff IanMatthewHuff marked this pull request as ready for review August 25, 2022 17:05
@IanMatthewHuff IanMatthewHuff requested a review from a team as a code owner August 25, 2022 17:05
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2022

Codecov Report

Merging #11191 (4a56550) into main (f0c4d6f) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #11191   +/-   ##
======================================
- Coverage     63%      63%   -1%     
======================================
  Files        485      485           
  Lines      34121    34121           
  Branches    5564     5564           
======================================
- Hits       21665    21651   -14     
- Misses     10398    10412   +14     
  Partials    2058     2058           
Impacted Files Coverage Δ
...interpreter/nbconvertExportToPythonService.node.ts 76% <0%> (-18%) ⬇️
src/notebooks/debugger/debugger.ts 66% <0%> (-12%) ⬇️
.../standalone/survey/dataScienceSurveyBanner.node.ts 66% <0%> (-6%) ⬇️
...kernels/jupyter/preferredRemoteKernelIdProvider.ts 92% <0%> (-5%) ⬇️
src/notebooks/debugger/debuggingManagerBase.ts 70% <0%> (-5%) ⬇️
src/platform/common/process/baseDaemon.node.ts 50% <0%> (-4%) ⬇️
src/notebooks/debugger/kernelDebugAdapterBase.ts 76% <0%> (-2%) ⬇️
src/kernels/raw/launcher/kernelProcess.node.ts 71% <0%> (-2%) ⬇️
src/platform/msrCrypto/msrCrypto.js 16% <0%> (-1%) ⬇️
src/kernels/common/baseJupyterSession.ts 80% <0%> (+<1%) ⬆️
... and 8 more

@IanMatthewHuff
Copy link
Member Author

Initial run of tests cleared the nbconvert failures, but I did see one failure with:
remote, nonConda, 3.9, desktop, ubuntu-latest - Kernel Event - Kernel Events

So trying a quick re-run to see if that is still there.

@IanMatthewHuff IanMatthewHuff merged commit abf5400 into main Aug 26, 2022
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/fixNBConvertTest branch August 26, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export a basic notebook document with nbconvert test is failing
3 participants