Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken macOS smoke test on CI #11194

Merged
merged 3 commits into from
Aug 26, 2022
Merged

Conversation

IanMatthewHuff
Copy link
Member

Fixes #11193

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2022

Codecov Report

Merging #11194 (08818ec) into main (1dcfca7) will decrease coverage by 0%.
The diff coverage is n/a.

❗ Current head 08818ec differs from pull request most recent head 5de3215. Consider uploading reports for the commit 5de3215 to get more accurate results

@@          Coverage Diff           @@
##            main   #11194   +/-   ##
======================================
- Coverage     63%      63%   -1%     
======================================
  Files        485      485           
  Lines      34121    34121           
  Branches    5564     5564           
======================================
- Hits       21663    21655    -8     
- Misses     10399    10402    +3     
- Partials    2059     2064    +5     
Impacted Files Coverage Δ
src/kernels/raw/session/rawJupyterSession.node.ts 79% <0%> (-3%) ⬇️
src/kernels/jupyter/finder/remoteKernelFinder.ts 87% <0%> (-2%) ⬇️
src/kernels/raw/session/rawSocket.node.ts 74% <0%> (-2%) ⬇️
.../standalone/survey/dataScienceSurveyBanner.node.ts 71% <0%> (ø)

@IanMatthewHuff IanMatthewHuff marked this pull request as ready for review August 25, 2022 20:45
@IanMatthewHuff IanMatthewHuff requested a review from a team as a code owner August 25, 2022 20:45
@IanMatthewHuff
Copy link
Member Author

IanMatthewHuff commented Aug 25, 2022

github-actions
Build and Test / Smoke tests (macos-latest, 3.9) (pull_request)

Was failing continually with a failure to download the darwin build on CI. Updated electron-test to check and I've seen two clean runs now for this test.

@IanMatthewHuff IanMatthewHuff merged commit 1c763ec into main Aug 26, 2022
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/fixMacOSSmokeTest branch August 26, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS smoke test is consistently failing on CI
3 participants