Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #11396 #11397

Closed
wants to merge 2 commits into from
Closed

Fix for issue #11396 #11397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e4e7d8
Fixed cell debugger problem with remote kernels
adam-zlatniczki Sep 16, 2022
e891929
Fixed cell debugger problem with remote kernels (#11396)
adam-zlatniczki Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions news/2 Fixes/11396.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fixed an interworking issue when running VSCode on Windows and connecting to a remote kernel that runs on some Unix distribution. Due to file path naming convention collisions, cell debugging failed.
(thanks [Adam Zlatniczki](https://github.com/adam-zlatniczki))
7 changes: 3 additions & 4 deletions src/notebooks/debugger/kernelDebugAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

'use strict';

import * as path from '../../platform/vscode-path/path';
import { IDumpCellResponse } from './debuggingTypes';
import { traceError } from '../../platform/logging';
import { KernelDebugAdapterBase } from './kernelDebugAdapterBase';
Expand All @@ -22,9 +21,9 @@ export class KernelDebugAdapter extends KernelDebugAdapterBase {
const response = await this.session.customRequest('dumpCell', {
code: cell.document.getText().replace(/\r\n/g, '\n')
});
const norm = path.normalize((response as IDumpCellResponse).sourcePath);
this.fileToCell.set(norm, cell.document.uri);
this.cellToFile.set(cell.document.uri.toString(), norm);
const pathOnKernelSide = (response as IDumpCellResponse).sourcePath;
this.fileToCell.set(pathOnKernelSide, cell.document.uri);
this.cellToFile.set(cell.document.uri.toString(), pathOnKernelSide);
} catch (err) {
traceError(err);
}
Expand Down