Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delay showing install python commands until after controllers are loaded #11430

Merged
merged 3 commits into from
Sep 22, 2022

Conversation

IanMatthewHuff
Copy link
Member

Fixes #10960

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@@ -98,7 +98,7 @@ export class InstallPythonControllerCommands implements IExtensionSingleActivati
}

private async onDidChangeActiveNotebookEditor(editor: NotebookEditor | undefined) {
if (!this.isWeb && editor) {
if (!this.isWeb && editor && editor.notebook.notebookType === JupyterNotebookView) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a gate for the view here. If we fix context in the kernel picker commands this can be moved to the when, but that support is not there yet.

@IanMatthewHuff IanMatthewHuff marked this pull request as ready for review September 21, 2022 23:55
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

Merging #11430 (4a8df3f) into main (428405b) will decrease coverage by 0%.
The diff coverage is 100%.

❗ Current head 4a8df3f differs from pull request most recent head f5692da. Consider uploading reports for the commit f5692da to get more accurate results

@@           Coverage Diff           @@
##            main   #11430    +/-   ##
=======================================
- Coverage     63%      63%    -1%     
=======================================
  Files        476      477     +1     
  Lines      33976    34154   +178     
  Branches    5508     5544    +36     
=======================================
+ Hits       21560    21603    +43     
- Misses     10357    10499   +142     
+ Partials    2059     2052     -7     
Impacted Files Coverage Δ
...ollers/commands/installPythonControllerCommands.ts 57% <100%> (ø)
src/notebooks/controllers/controllerLoader.ts 92% <100%> (+4%) ⬆️
src/kernels/jupyter/serverSelector.ts 43% <0%> (-19%) ⬇️
src/platform/common/platform/fileSystem.ts 35% <0%> (-9%) ⬇️
.../standalone/survey/dataScienceSurveyBanner.node.ts 66% <0%> (-6%) ⬇️
src/kernels/kernelStartupCodeProvider.node.ts 76% <0%> (-6%) ⬇️
...interactive-window/debugger/startupCodeProvider.ts 87% <0%> (-4%) ⬇️
src/kernels/jupyter/launcher/serverUriStorage.ts 64% <0%> (-4%) ⬇️
src/platform/common/platform/fileSystem.node.ts 67% <0%> (-3%) ⬇️
src/platform/common/application/extensions.node.ts 84% <0%> (-3%) ⬇️
... and 18 more

@IanMatthewHuff IanMatthewHuff merged commit 06ca869 into main Sep 22, 2022
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/fixInstallPythonCommands branch September 22, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Install Python' command is showing up in kernel picker even when python extension is installed
3 participants