Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not dispose kernel message handler for a cell when cell completes execution #11542

Merged
merged 5 commits into from
Oct 7, 2022

Conversation

DonJayamanne
Copy link
Contributor

Fixes #11526

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #11542 (b7932d9) into main (c06b44d) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #11542   +/-   ##
======================================
  Coverage     63%      63%           
======================================
  Files        477      477           
  Lines      34059    34058    -1     
  Branches    5527     5526    -1     
======================================
+ Hits       21507    21519   +12     
+ Misses     10497    10481   -16     
- Partials    2055     2058    +3     
Impacted Files Coverage Δ
src/kernels/execution/cellExecution.ts 72% <ø> (-1%) ⬇️
src/kernels/execution/notebookUpdater.ts 88% <0%> (-8%) ⬇️
src/platform/common/cancellation.ts 64% <0%> (-4%) ⬇️
src/kernels/jupyter/jupyterKernelService.node.ts 72% <0%> (-2%) ⬇️
src/platform/common/utils/decorators.ts 91% <0%> (+<1%) ⬆️
...c/kernels/execution/cellExecutionMessageHandler.ts 78% <0%> (+1%) ⬆️
src/kernels/raw/finder/localKernelFinder.node.ts 76% <0%> (+1%) ⬆️
src/kernels/helpers.ts 68% <0%> (+1%) ⬆️
src/platform/common/utils/async.ts 51% <0%> (+1%) ⬆️
.../standalone/survey/dataScienceSurveyBanner.node.ts 71% <0%> (+5%) ⬆️

@DonJayamanne DonJayamanne merged commit 6c16907 into main Oct 7, 2022
@DonJayamanne DonJayamanne deleted the issue11526 branch October 7, 2022 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cell execution does not seem to work when using async Python code
4 participants