Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually get png image size #12017

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Manually get png image size #12017

merged 1 commit into from
Nov 14, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Nov 14, 2022

Part of #11996

Referenced png spec: https://www.w3.org/TR/2003/REC-PNG-20031110/

I didn't manually test this but the unit test works (based on icon.png).


Total web bundle size 4.88MB -> 4.85MB
Module size: 33.06KB

@Tyriar Tyriar added this to the November 2022 milestone Nov 14, 2022
@Tyriar Tyriar requested a review from rebornix November 14, 2022 17:57
@Tyriar Tyriar self-assigned this Nov 14, 2022
@rebornix rebornix merged commit 890dd7a into main Nov 14, 2022
@rebornix rebornix deleted the tyriar/image-size branch November 14, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants