Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove named-js-group #12035

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Remove named-js-group #12035

merged 3 commits into from
Nov 17, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Nov 15, 2022

uglify-js doesn't appear to be in the project anymore and it seems that was the only reason it was included based on a comment? Regardless, support is good for named capture group in all browsers/node now.

Part of #11996

image

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp#browser_compatibility

uglify-js doesn't appear to be in the project anymore and it seems that
was the only reason it was included based on a comment? Regardless,
support is good for named capture group in all browsers/node now.

Part of #11996
@Tyriar Tyriar added this to the November 2022 milestone Nov 15, 2022
@Tyriar Tyriar requested a review from rebornix November 15, 2022 19:45
@Tyriar Tyriar self-assigned this Nov 15, 2022
@Tyriar Tyriar changed the title Remove named-js-group and @types/uglify-js Remove named-js-group Nov 15, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Nov 15, 2022

@types/uglify-js is actually used via @types/html-minifier-terser

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2022

Codecov Report

Merging #12035 (fb7c7e1) into main (da681ee) will decrease coverage by 0%.
The diff coverage is 50%.

@@           Coverage Diff           @@
##            main   #12035    +/-   ##
=======================================
- Coverage     62%      62%    -1%     
=======================================
  Files        502      502            
  Lines      35918    35916     -2     
  Branches    5813     5813            
=======================================
- Hits       22545    22312   -233     
- Misses     11232    11493   +261     
+ Partials    2141     2111    -30     
Impacted Files Coverage Δ
src/kernels/helpers.ts 66% <0%> (-1%) ⬇️
...kernels/jupyter/launcher/jupyterConnection.node.ts 75% <100%> (-9%) ⬇️
...otebooks/debugger/controllers/restartController.ts 10% <0%> (-75%) ⬇️
...ebooks/debugger/controllers/runByLineController.ts 13% <0%> (-66%) ⬇️
src/notebooks/debugger/kernelDebugAdapter.ts 20% <0%> (-65%) ⬇️
src/notebooks/debugger/debuggingManager.ts 30% <0%> (-50%) ⬇️
src/kernels/errors/jupyterKernelDependencyError.ts 57% <0%> (-43%) ⬇️
src/notebooks/debugger/kernelDebugAdapterBase.ts 57% <0%> (-19%) ⬇️
src/notebooks/debugger/commandRegistry.ts 37% <0%> (-15%) ⬇️
...kernels/jupyter/session/backingFileCreator.base.ts 68% <0%> (-13%) ⬇️
... and 39 more

@Tyriar Tyriar enabled auto-merge (squash) November 16, 2022 16:08
@Tyriar Tyriar merged commit c5e071e into main Nov 17, 2022
@Tyriar Tyriar deleted the tyriar/capture-group branch November 17, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants