-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove msrCrypto in favor of native APIs #12050
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
previously approved these changes
Nov 16, 2022
connor4312
previously approved these changes
Nov 16, 2022
Tyriar
force-pushed
the
tyriar/msrCrypto
branch
from
November 16, 2022 22:20
59c2725
to
b3015c7
Compare
I see this in the Lint task, but it's still passing:
|
Codecov Report
@@ Coverage Diff @@
## main #12050 +/- ##
========================================
+ Coverage 63% 70% +6%
========================================
Files 497 495 -2
Lines 35701 30989 -4712
Branches 5468 4861 -607
========================================
- Hits 22677 21759 -918
+ Misses 11082 7384 -3698
+ Partials 1942 1846 -96
|
@Tyriar I suggest using the IgnorePlugin to ignore |
Merged
DonJayamanne
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msrCrypto is a polyfill for the native APIs which are well supported in browser and node currently. The module also recommends using native APIs when they are available.
Fixes #12023
Part of #11996