Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable local kernel and local python for web #12276

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Conversation

DonJayamanne
Copy link
Contributor

No description provided.

@DonJayamanne DonJayamanne added the candidate Issue identified as probable candidate for fixing in the next release label Dec 2, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #12276 (44d0436) into main (320b783) will decrease coverage by 0%.
The diff coverage is 25%.

@@          Coverage Diff           @@
##            main   #12276   +/-   ##
======================================
- Coverage     69%      69%   -1%     
======================================
  Files        501      501           
  Lines      31907    31909    +2     
  Branches    4998     4999    +1     
======================================
- Hits       22275    22244   -31     
- Misses      7775     7787   +12     
- Partials    1857     1878   +21     
Impacted Files Coverage Δ
...rollers/kernelSource/kernelSourceCommandHandler.ts 32% <25%> (+<1%) ⬆️
.../notebooks/controllers/controllerDefaultService.ts 61% <0%> (-8%) ⬇️
src/kernels/installer/productInstaller.node.ts 74% <0%> (-5%) ⬇️
src/kernels/kernelDependencyService.node.ts 80% <0%> (-4%) ⬇️
...c/platform/common/process/pythonDaemonPool.node.ts 78% <0%> (-2%) ⬇️
src/kernels/helpers.ts 68% <0%> (-2%) ⬇️
src/notebooks/controllers/kernelRanking/helpers.ts 60% <0%> (-2%) ⬇️
src/platform/api/pythonApi.ts 70% <0%> (-1%) ⬇️
...c/platform/interpreter/interpreterPackages.node.ts 73% <0%> (-1%) ⬇️
.../notebooks/controllers/vscodeNotebookController.ts 85% <0%> (-1%) ⬇️
... and 11 more

@rebornix rebornix self-requested a review December 2, 2022 18:49
@rebornix rebornix marked this pull request as ready for review December 2, 2022 18:49
@rebornix rebornix removed the candidate Issue identified as probable candidate for fixing in the next release label Dec 2, 2022
@rebornix rebornix merged commit 68fd872 into main Dec 2, 2022
@rebornix rebornix deleted the newKernelPickerForWeb branch December 2, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants