Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use serializable type for cached owner #13729

Merged
merged 1 commit into from
Jun 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/interactive-window/interactiveWindowProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export class InteractiveWindowProvider implements IInteractiveWindowProvider, IE

const result = new InteractiveWindow(
this.serviceContainer,
iw.owner,
Uri.parse(iw.owner),
new InteractiveControllerFactory(this.controllerHelper, mode),
tab,
Uri.parse(iw.inputBoxUriString)
Expand Down Expand Up @@ -319,7 +319,7 @@ export class InteractiveWindowProvider implements IInteractiveWindowProvider, IE
const windowCache = this._windows.map(
(iw) =>
({
owner: iw.owner,
owner: iw.owner?.toString(),
uriString: iw.notebookUri.toString(),
inputBoxUriString: iw.inputUri.toString()
} as IInteractiveWindowCache)
Expand Down
2 changes: 1 addition & 1 deletion src/interactive-window/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export interface IInteractiveWindow extends IInteractiveBase {
}

export interface IInteractiveWindowCache {
owner: Resource;
owner: string;
mode: InteractiveWindowMode;
uriString: string;
inputBoxUriString: string;
Expand Down