Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to write references. #14510

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Improvements to write references. #14510

merged 3 commits into from
Oct 16, 2023

Conversation

rebornix
Copy link
Member

Re #14316

Improvements to the code execution analysis:

  • Mark all symbol definition as write operation.
  • Unify select dependent cells and run dependent cells commands.
  • Better handling of write references.
  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@rebornix rebornix changed the title Handle symbol modification Improvements to write references. Oct 15, 2023
@rebornix rebornix self-assigned this Oct 15, 2023
@rebornix rebornix marked this pull request as ready for review October 15, 2023 04:55
@rebornix rebornix merged commit f2d086a into main Oct 16, 2023
32 checks passed
@rebornix rebornix deleted the rebornix/faithful-butterfly branch October 16, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants