Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies in package-lock.json #14578

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Update dependencies in package-lock.json #14578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dca92be
Update dependencies in package-lock.json
DonJayamanne Oct 26, 2023
e36a9b0
Add noop import and handle promise rejections in
DonJayamanne Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 33 additions & 30 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions src/test/datascience/widgets/standardWidgets.vscode.common.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import { initializeWidgetComms, Utils } from './commUtils';
import { WidgetRenderingTimeoutForTests } from './constants';
import { getTextOutputValue } from '../../../kernels/execution/helpers';
import { isWeb } from '../../../platform/common/utils/misc';
import { noop } from '../../core';

const templateRootPath: Uri =
workspace.workspaceFolders && workspace.workspaceFolders.length > 0
Expand Down Expand Up @@ -133,8 +134,8 @@ suite('Standard IPyWidget Tests @widgets', function () {
// and the output is not visible, then it will not get rendered & the tests will fail. The tests inspect the rendered HTML.
// Solution - maximize available real-estate by hiding the output panels & hiding the input cells.
await commands.executeCommand('workbench.action.closePanel');
await commands.executeCommand('workbench.action.maximizeEditorGroup');
await commands.executeCommand('notebook.cell.collapseAllCellInputs');
await commands.executeCommand('workbench.action.maximizeEditorGroup').then(noop, noop);
await commands.executeCommand('notebook.cell.collapseAllCellInputs').then(noop, noop);
comms = await initializeWidgetComms(disposables);

vscodeNotebook = api.serviceContainer.get<IVSCodeNotebook>(IVSCodeNotebook);
Expand Down
3 changes: 2 additions & 1 deletion src/test/datascience/widgets/thirdpartyWidgets.vscode.common.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import { GlobalStateKeyToTrackIfUserConfiguredCDNAtLeastOnce } from '../../../no
import { initializeWidgetComms, Utils } from './commUtils';
import { isWeb } from '../../../platform/common/utils/misc';
import { getTextOutputValue } from '../../../kernels/execution/helpers';
import { noop } from '../../core';

[true, false].forEach((useCDN) => {
/* eslint-disable @typescript-eslint/no-explicit-any, no-invalid-this */
Expand Down Expand Up @@ -80,7 +81,7 @@ import { getTextOutputValue } from '../../../kernels/execution/helpers';
// and the output is not visible, then it will not get rendered & the tests will fail. The tests inspect the rendered HTML.
// Solution - maximize available real-estate by hiding the output panels & hiding the input cells.
await commands.executeCommand('workbench.action.closePanel');
await commands.executeCommand('workbench.action.maximizeEditorGroup');
await commands.executeCommand('workbench.action.maximizeEditorGroup').then(noop, noop);
comms = await initializeWidgetComms(disposables);

vscodeNotebook = api.serviceContainer.get<IVSCodeNotebook>(IVSCodeNotebook);
Expand Down
Loading