Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the infinite loop on getListOfKernelsWithCachedConnection #15252

Merged

Conversation

andyscho
Copy link
Contributor

@andyscho andyscho commented Feb 27, 2024

Fixes #15251

If running with cache and hit a failure (either when resolving initial promise or the listKernelsFromConnection), run again ignoring the cache. Don't loop repeatedly or perform more retries, though if this is desired, it can be changed.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@vscodenpa vscodenpa added this to the March 2024 milestone Feb 28, 2024
@DonJayamanne DonJayamanne merged commit d331387 into microsoft:main Feb 28, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getListOfKernelsWithCachedConnection() can infinite loop
4 participants