Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce warning/debug messages #15361

Merged
merged 6 commits into from
Mar 14, 2024
Merged

Conversation

DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Mar 14, 2024

@DonJayamanne DonJayamanne changed the title Do not log unnecessary warning msgs Reduce warning/debug messages Mar 14, 2024
@DonJayamanne DonJayamanne marked this pull request as ready for review March 14, 2024 18:28
@vscodenpa vscodenpa added this to the March 2024 milestone Mar 14, 2024
@DonJayamanne DonJayamanne enabled auto-merge (squash) March 14, 2024 18:33
Comment on lines 274 to +280
const pylanceExtension = extensions.getExtension(PylanceExtension);
if (pylanceExtension) {
standardOutputChannel.appendLine(`Pylance Extension Version: ${pylanceExtension.packageJSON['version']}.`);
standardOutputChannel.appendLine(
`Pylance Extension Version${isUsingPylance() ? '' : ' (Not Used) '}: ${
pylanceExtension.packageJSON['version']
}.`
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opportunity to share code with the .node side

@DonJayamanne DonJayamanne merged commit df25cd4 into main Mar 14, 2024
28 checks passed
@DonJayamanne DonJayamanne deleted the ignoreIPYKernelWarningMessages branch March 14, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants