Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: exclude ARM64 binaries from APIScan #15609

Merged
merged 3 commits into from
Apr 26, 2024
Merged

chore: exclude ARM64 binaries from APIScan #15609

merged 3 commits into from
Apr 26, 2024

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Apr 26, 2024 •
edited
Loading

Verification build: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=270625&view=results

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@rzhao271 rzhao271 self-assigned this Apr 26, 2024
@rzhao271 rzhao271 added this to the May 2024 milestone Apr 26, 2024
@rzhao271 rzhao271 force-pushed the rzhao271/arm-apiscan branch from 4e0ad26 to 6b93467 Compare April 26, 2024 18:59
@rzhao271 rzhao271 marked this pull request as ready for review April 26, 2024 19:34
@rzhao271 rzhao271 merged commit 6cbf5e0 into main Apr 26, 2024
44 checks passed
@rzhao271 rzhao271 deleted the rzhao271/arm-apiscan branch April 26, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeschli aeschli aeschli approved these changes

Assignees

@rzhao271 rzhao271

Labels
None yet
Projects
None yet
Milestone
May 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@rzhao271 @aeschli