Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move variable providers to /standalone #15627

Merged
merged 7 commits into from
Apr 30, 2024
Merged

move variable providers to /standalone #15627

merged 7 commits into from
Apr 30, 2024

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Apr 29, 2024 •
edited
Loading

  • move variable providers to standalone
    • a lot of changes are just to point to the new filepath
  • remove the background thread service
    • it was only introduced to allow usage from outside of standalone
  • only have one variable provider, the variable sets are based on notebook, so having one per controller is unnecessary

@amunger amunger marked this pull request as ready for review April 30, 2024 18:11
@vscodenpa vscodenpa added this to the April 2024 milestone Apr 30, 2024
@amunger amunger merged commit 9cd3155 into main Apr 30, 2024
28 checks passed
@amunger amunger deleted the aamunger/variableProvider branch April 30, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@rebornix rebornix Awaiting requested review from rebornix

Assignees

@amunger amunger

Labels
None yet
Projects
None yet
Milestone
April 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@amunger @DonJayamanne @vscodenpa