prompt to change back to previous IW execute keybinding

package.json

@@ -144,11 +144,6 @@
                 "key": "alt+enter",
                 "when": "editorTextFocus && !editorHasSelection && jupyter.hascodecells && !notebookEditorFocused"
             },
-            {
-                "key": "shift+enter",
-                "when": "activeEditor == 'workbench.editor.interactive' && notebookKernel =~ /^ms-toolsai.jupyter\\// || activeEditor == 'workbench.editor.interactive' && !notebookKernel",
-                "command": "interactive.execute"
-            },
             {
                 "key": "escape",
                 "when": "activeEditor == 'workbench.editor.interactive' && !editorHoverVisible && !suggestWidgetVisible && !isComposing && !inSnippetMode && !exceptionWidgetVisible && !selectionAnchorSet && !LinkedEditingInputVisible && !renameInputVisible && !editorHasSelection && !accessibilityHelpWidgetVisible && !breakpointWidgetVisible && !findWidgetVisible && !markersNavigationVisible && !parameterHintsVisible && !editorHasMultipleSelections && !notificationToastsVisible",

src/notebooks/controllers/InteractiveExecutionPrompt.ts

@@ -0,0 +1,49 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+import { ConfigurationTarget, NotebookCell, window, workspace } from 'vscode';
+import { IConfigurationService } from '../../platform/common/types';
+
+export class InteractiveExecutionPrompt {
+    private disabled = false;
+
+    constructor(private readonly configurationService: IConfigurationService) {}
+
+    public async checkToPrompt(cell: NotebookCell) {
+        if (this.disabled) {
+            return;
+        }
+        if (cell.notebook.notebookType === 'interactive' && !cell.metadata.interactive) {
+            const settings = this.configurationService.getSettings(cell.document.uri);
+            const config = workspace.getConfiguration('interactiveWindow');
+            const setting = config.get('executeWithShiftEnter');
+
+            // can we check if the keybinding for interactive.execute is set to 'enter'?
+            if (!settings.promptToChangeInteractiveExecute || setting === undefined || setting === true) {
+                return;
+            }
+
+            const response = await window.showInformationMessage(
+                'Change execute keyboard shortcut to shift+enter? (previous behavior)',
+                'shift+enter to execute',
+                'enter to execute'
+            );
+            switch (response) {
+                case 'shift+enter to execute': {
+                    await config.update('executeWithShiftEnter', true, ConfigurationTarget.Global);
+                    await this.configurationService.updateSetting('promptToChangeInteractiveExecute', false);
+                    break;
+                }
+                case 'enter to execute': {
+                    await this.configurationService.updateSetting('promptToChangeInteractiveExecute', false);
+                    break;
+                }
+                default:
+                    {
+                    }
+
+                    this.disabled = true;
+            }
+        }
+    }
+}

src/notebooks/controllers/vscodeNotebookController.ts

@@ -84,6 +84,7 @@ import { getVersion } from '../../platform/interpreter/helpers';
 import { getNotebookTelemetryTracker, trackControllerCreation } from '../../kernels/telemetry/notebookTelemetry';
 import { IJupyterVariablesProvider } from '../../kernels/variables/types';
 import type { INotebookMetadata } from '@jupyterlab/nbformat';
+import { InteractiveExecutionPrompt } from './InteractiveExecutionPrompt';
 
 /**
  * Our implementation of the VSCode Notebook Controller. Called by VS code to execute cells in a notebook. Also displayed
@@ -103,6 +104,7 @@ export class VSCodeNotebookController implements Disposable, IVSCodeNotebookCont
     private readonly _onDidDispose = new EventEmitter<void>();
     private readonly disposables: IDisposable[] = [];
     private notebookKernels = new WeakMap<NotebookDocument, IKernel>();
+    private interactiveExecutionPrompt: InteractiveExecutionPrompt;
     public readonly controller: NotebookController;
     /**
      * Used purely for testing purposes.
@@ -228,6 +230,7 @@ export class VSCodeNotebookController implements Disposable, IVSCodeNotebookCont
             this,
             this.disposables
         );
+        this.interactiveExecutionPrompt = new InteractiveExecutionPrompt(this.configuration);
     }
 
     private readonly restoredConnections = new WeakSet<NotebookDocument>();
@@ -367,6 +370,7 @@ export class VSCodeNotebookController implements Disposable, IVSCodeNotebookCont
         if (cells.length < 1) {
             return;
         }
+        await this.interactiveExecutionPrompt.checkToPrompt(cells[0]);
         const tracker = getNotebookTelemetryTracker(notebook);
         tracker?.cellExecutionCount(cells.length);
         const telemetryTracker = tracker?.preExecuteCellTelemetry();
@@ -398,6 +402,7 @@ export class VSCodeNotebookController implements Disposable, IVSCodeNotebookCont
         // Notebook is trusted. Continue to execute cells
         await Promise.all(cells.map((cell) => this.executeCell(notebook, cell)));
     }
+
     private async onDidChangeSelectedNotebooks(event: { notebook: NotebookDocument; selected: boolean }) {
         logger.ci(
             `NotebookController selection event called for notebook ${event.notebook.uri.toString()} & controller ${

src/platform/common/configSettings.ts

@@ -88,6 +88,7 @@ export class JupyterSettings implements IWatchableJupyterSettings {
     public excludeUserSitePackages: boolean = false;
     public enableExtendedPythonKernelCompletions: boolean = false;
     public formatStackTraces: boolean = false;
+    public promptToChangeInteractiveExecute: boolean = true;
     // Privates should start with _ so that they are not read from the settings.json
     private _changeEmitter = new EventEmitter<void>();
     private _workspaceRoot: Resource;

src/platform/common/types.ts

@@ -93,6 +93,7 @@ export interface IJupyterSettings {
     readonly excludeUserSitePackages: boolean;
     readonly enableExtendedPythonKernelCompletions: boolean;
     readonly formatStackTraces: boolean;
+    readonly promptToChangeInteractiveExecute: boolean;
     /**
      * Trigger characters for Jupyter completion, per language.
      * This excludes the trigger characters for python.