Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address codeQL issues #15724

Merged
merged 1 commit into from
May 28, 2024
Merged

Address codeQL issues #15724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test/datascience/jupyterServer.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ export class JupyterServer {
}

function generateHashedPassword(password: string) {
const hash = crypto.createHash('sha1');
const hash = crypto.createHash('sha1'); // CodeQL [SM04514] This is used only in tests and not in production. Also this is a requirement of the Jupyter Application (out of our control).
const salt = genRandomString(16);
hash.update(password); // CodeQL [SM01511] This password is hashed as per the requirements of Jupyter Server application, it is only used in tests (to launch a password protected jupyter server) and not production.
hash.update(salt);
Expand Down
2 changes: 0 additions & 2 deletions src/webviews/webview-side/data-explorer/globalJQueryImports.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ After that we need to load slickgrid, and then the jQuery plugin from slickgrid
// use slickgridJQ instead of the usual $ to make it clear that we need that JQ and not
// the one currently in node-modules

// eslint-disable-next-line @typescript-eslint/no-var-requires, @typescript-eslint/no-require-imports
require('slickgrid/lib/jquery-1.11.2.min');

// eslint-disable-next-line @typescript-eslint/no-var-requires, @typescript-eslint/no-require-imports
require('slickgrid/lib/jquery.event.drag-2.3.0');
Loading