Make display_name changes also cause a kernel change event #15967
+31
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
commented
Aug 28, 2024
src/kernels/jupyter/interpreter/jupyterInterpreterSubCommandExecutionService.unit.test.ts
Show resolved
Hide resolved
DonJayamanne
approved these changes
Sep 2, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ##15965
This should fix (for the most part) the problem where a kernel change does not cause a kernel change event. Granted it would be better if it always fired an event, but this at least is consistent with the model before (ipynb file changes, then fire the event). AFAICT,
display_nameis saved in the ipynb file so this seems like what the behavior should have been before.