Remove more unnecessary interpreter types #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Sep 14, 2020
| @@ -87,6 +92,7 @@ | |||
| "no-control-regex": "off", | |||
| "function-paren-newline": "off", | |||
| "consistent-return": "off", | |||
| "class-methods-use-this": "off", | |||
There was a problem hiding this comment.
For existing code.
DonJayamanne
commented
Sep 14, 2020
| @@ -33,7 +33,12 @@ | |||
| "@typescript-eslint/no-empty-interface": "off", | |||
| "@typescript-eslint/no-non-null-assertion": "off", | |||
| "no-unused-vars": "off", | |||
| "@typescript-eslint/no-unused-vars": "error", | |||
| "@typescript-eslint/no-unused-vars": [ | |||
There was a problem hiding this comment.
For existing code
DonJayamanne
commented
Sep 14, 2020
| /** | ||
| * The supported Python environment types. | ||
| */ | ||
| export enum EnvironmentType { |
There was a problem hiding this comment.
Not used in DS code.
DonJayamanne
commented
Sep 14, 2020
| @@ -64,7 +45,4 @@ export type InterpreterInformation = { | |||
| // and doesn't really belong here. | |||
| export type PythonEnvironment = InterpreterInformation & { | |||
| displayName?: string; | |||
| envType: EnvironmentType; | |||
| envName?: string; | |||
| envPath?: string; | |||
There was a problem hiding this comment.
None of these were used in DS code, only in tests.
DonJayamanne
commented
Sep 14, 2020
| // Eventually we will want to also support the release serial | ||
| // (e.g. beta1, candidate3) and maybe even release abbreviations | ||
| // (e.g. 3.9.2b1, 3.8.10rc3). | ||
| export function parsePythonVersion(raw: string): PythonVersion | undefined { |
There was a problem hiding this comment.
Only used in tests, hence moved to tests folder.
DonJayamanne
requested review from
IanMatthewHuff,
rchiodo,
DavidKutu,
joyceerhl and
greazer
rchiodo
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #28
Added some code for conda interpreters (copied from core extension, into tests folder).
Manually Tested: