Skip to content

Remove more unnecessary interpreter types #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2020
Merged

Remove more unnecessary interpreter types #31

merged 1 commit into from
Sep 14, 2020

Conversation

@DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Sep 14, 2020 •
edited
Loading

For #28
Added some code for conda interpreters (copied from core extension, into tests folder).

Manually Tested:

  • Native notebooks
  • Old notebooks
  • Interactive window

DonJayamanne
DonJayamanne commented Sep 14, 2020
View reviewed changes
.eslintrc Outdated
Copy link
Contributor Author

@DonJayamanne DonJayamanne Sep 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For existing code.

DonJayamanne
DonJayamanne commented Sep 14, 2020
View reviewed changes
.eslintrc Outdated
Copy link
Contributor Author

@DonJayamanne DonJayamanne Sep 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For existing code

DonJayamanne
DonJayamanne commented Sep 14, 2020
View reviewed changes
src/client/pythonEnvironments/info/index.ts Outdated
Copy link
Contributor Author

@DonJayamanne DonJayamanne Sep 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used in DS code.

DonJayamanne
DonJayamanne commented Sep 14, 2020
View reviewed changes
src/client/pythonEnvironments/info/index.ts Outdated
Copy link
Contributor Author

@DonJayamanne DonJayamanne Sep 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these were used in DS code, only in tests.

DonJayamanne
DonJayamanne commented Sep 14, 2020
View reviewed changes
src/client/pythonEnvironments/info/pythonVersion.ts Outdated
Copy link
Contributor Author

@DonJayamanne DonJayamanne Sep 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only used in tests, hence moved to tests folder.

@DonJayamanne DonJayamanne merged commit c39192a into microsoft:main Sep 14, 2020
@DonJayamanne DonJayamanne deleted the removeInterpreterTypes branch September 14, 2020 21:12
@DonJayamanne DonJayamanne mentioned this pull request Sep 16, 2020
Merged
@andvsilva andvsilva mentioned this pull request Nov 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rchiodo rchiodo rchiodo approved these changes

@IanMatthewHuff IanMatthewHuff Awaiting requested review from IanMatthewHuff

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

@joyceerhl joyceerhl Awaiting requested review from joyceerhl

@greazer greazer Awaiting requested review from greazer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DonJayamanne @rchiodo