Add copy of Python Extension API service for functional tests #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Sep 14, 2020
| @@ -7,5 +7,4 @@ export interface IInterpreterService { | |||
| getInterpreters(resource?: Uri): Promise<PythonEnvironment[]>; | |||
| getActiveInterpreter(resource?: Uri): Promise<PythonEnvironment | undefined>; | |||
| getInterpreterDetails(pythonPath: string, resource?: Uri): Promise<undefined | PythonEnvironment>; | |||
| initialize(): void; | |||
There was a problem hiding this comment.
Only used in tests.
DonJayamanne
commented
Sep 14, 2020
| @@ -560,12 +560,6 @@ suite('DataScience notebook tests', () => { | |||
| // Rewire our data we use to search for processes | |||
| @injectable() | |||
| class EmptyInterpreterService implements IInterpreterService { | |||
| public get hasInterpreters(): Promise<boolean> { | |||
There was a problem hiding this comment.
Redundant code
DonJayamanne
requested review from
rchiodo,
IanMatthewHuff,
joyceerhl,
DavidKutu and
greazer
DonJayamanne
changed the title
rchiodo
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #28
Tests are slow, still going through what needs to be fixed.
However this addresses a huge chunk of the tests.
As I come across other tests, I'll fix them.