Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix survey prompt for Native notebooks #4021

Merged
merged 3 commits into from
Nov 25, 2020
Merged

Fix survey prompt for Native notebooks #4021

merged 3 commits into from
Nov 25, 2020

Conversation

DonJayamanne
Copy link
Contributor

For #4002

@DonJayamanne DonJayamanne requested a review from a team as a code owner November 25, 2020 00:21
joyceerhl
joyceerhl approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@joyceerhl joyceerhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these 😊 I wrote a test for this banner that is likely completely useless, I can update it in a separate PR

@DonJayamanne DonJayamanne merged commit a9e6437 into main Nov 25, 2020
@DonJayamanne DonJayamanne deleted the issue4002Part2 branch November 25, 2020 01:17
DonJayamanne added a commit that referenced this pull request Nov 25, 2020
@DonJayamanne
Fix survey prompt for Native notebooks (#4021)
e73792c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidKutu DavidKutu DavidKutu approved these changes

@joyceerhl joyceerhl joyceerhl approved these changes

@greazer greazer Awaiting requested review from greazer

@IanMatthewHuff IanMatthewHuff Awaiting requested review from IanMatthewHuff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DonJayamanne @DavidKutu @joyceerhl